Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-17 Thread yuppie
Roger Ineichen wrote: What about testing it like this: We remove the 'else' part and wait until someone complains. In that case we have a scenario for testing and fixing the issue. If nobody complains, the 'else' part was indeed useless. The current code doesn't work for me because 'src'

Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-17 Thread yuppie
Hi Roger! 1.) running tests - Proposal: Remove those two lines in test.py. Done. 2.) looking up the product version -- Proposal: Catch the error. Return an empty string if version is not found. The problem was somewhere different:

Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-17 Thread Roger Ineichen
Hi Yuppie Betreff: Re: z3c.recipe.i18n and zope.app.locales.extract Hi Roger! 1.) running tests - Proposal: Remove those two lines in test.py. Done. 2.) looking up the product version -- Proposal: Catch the error. Return

Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-17 Thread yuppie
Roger Ineichen wrote: 5. writing makers - Proposal: Pass in the additional arguments and fall back to the old signature for BBB. Done. I also added site_zcml as argument. What about wrapping py_strings, zcml_strings and tal_strings in functions that implement the new

Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-16 Thread Roger Ineichen
Hi yuppie -Ursprüngliche Nachricht- Von: zope-dev-bounces+dev=projekt01...@zope.org [mailto:zope-dev-bounces+dev=projekt01...@zope.org] Im Auftrag von yuppie Gesendet: Mittwoch, 15. Juli 2009 21:04 An: Zope-Dev List Betreff: [Zope-dev] z3c.recipe.i18n

Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-16 Thread yuppie
Hi Roger, Thanks for your feedback! Roger Ineichen wrote: -Ursprüngliche Nachricht- 2.) looking up the product version -- POTMaker._getProductVersion() doesn't work for me. zope.app.applicationcontrol is not used by Zope 2 and is not part of the

Re: [Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-16 Thread Roger Ineichen
Hi Yuppie Betreff: Re: z3c.recipe.i18n and zope.app.locales.extract Hi Roger, Thanks for your feedback! Roger Ineichen wrote: -Ursprüngliche Nachricht- 2.) looking up the product version -- POTMaker._getProductVersion() doesn't work

[Zope-dev] z3c.recipe.i18n and zope.app.locales.extract

2009-07-15 Thread yuppie
Hi! I plan to use z3c.recipe.i18n for some Zope 2 CMF products. But to get things working I did have to modify z3c.recipe.i18n a bit. It would be nice if I could get some feedback regarding the issues I found: 1.) running tests - test.py tries to install 'zodbcode' and