Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1010746 into lp:zorba/image-module

2012-08-15 Thread Chris Hillery
Review: Approve Beautiful change. I'll vote Approve based on a reading of the code, but I can't actually test it; hopefully Juan can verify that an appropriate pretty error is thrown on a machine without ImageMagick installer. -- https://code.launchpad.net/~zorba-coders/zorba/bug1010746/+merge/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-15 Thread Paul J. Lucas
> 1. Are the things you compile/link against on Windows and Mac guaranteed to > exist? (ie, do I only need to find libuuid on Linux platforms) Yes. > 2. What should happen if I *don't* find it? Can the UUID code be made optional > at compile time? Would that mean we need a ZORBA_WITH_UUID or some

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-15 Thread Chris Hillery
> Good catch. I don't suppose you could add the relevant CMake stuff to find > libuuid? 1. Are the things you compile/link against on Windows and Mac guaranteed to exist? (ie, do I only need to find libuuid on Linux platforms) 2. What should happen if I *don't* find it? Can the UUID code be mad

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread noreply
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue job fn_trace_jsoniq_fix-2012-08-15T15-41-05.154Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpa

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fn_trace_jsoniq_fix-2012-08-15T15-41-05.154Z/log.html -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- M

[Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Till Westmann
The proposal to merge lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_json

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread Till Westmann
Review: Approve Of course! I'm sorry about the confusion. -- https://code.launchpad.net/~davidagraf/zorba/fn_trace_jsoniq_fix/+merge/119478 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.ne

Re: [Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2012-08-15 Thread Paul J. Lucas
Review: Approve -- https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/119730 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-uuid into lp:zorba

2012-08-15 Thread Paul J. Lucas
> My only concern is that for non-Apple, non-Windows platforms, you add -luuid > to the link line, but there's no CMake stuff to search for a uuid library or > to ensure that such an option will compile/link successfully. Is it a > guarantee that it will always be available, at least on Linux? Goo

[Zorba-coders] [Merge] lp:~paul-lucas/zorba/pjl-misc into lp:zorba

2012-08-15 Thread Paul J. Lucas
Paul J. Lucas has proposed merging lp:~paul-lucas/zorba/pjl-misc into lp:zorba. Requested reviews: Paul J. Lucas (paul-lucas) For more details, see: https://code.launchpad.net/~paul-lucas/zorba/pjl-misc/+merge/119730 Miscellaneous changes, some a prerequisite for LLVM that should be done anywa

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1. Got: 1 Approve, 2 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue job jsoniq-library-functions-2012-08-15T14-11-15.358Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/jsoniq-library-functions-2012-08-15T14-11-15.358Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:z

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zor

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Zorba Build Bot
There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba

2012-08-15 Thread Ghislain Fourny
The proposal to merge lp:~zorba-coders/zorba/jsoniq-library-functions into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-library-functions/+merge/119347 -- https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba

2012-08-15 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/expr-memman2 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/1

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba

2012-08-15 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/expr-memman2 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274 (message): Validation queue job expr-memman2-2012-08-15T09-57-04.577Z is finished. The final

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/expr-memman2-2012-08-15T09-57-04.577Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba

2012-08-15 Thread Markos Zaharioudakis
The proposal to merge lp:~zorba-coders/zorba/expr-memman2 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/1

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/expr-memman2 into lp:zorba

2012-08-15 Thread Markos Zaharioudakis
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/expr-memman2/+merge/119523 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-15 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-mod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue job add-archive-module-2012-08-15T07-45-11.735Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpa

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-15 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/add-archive-module-2012-08-15T07-45-11.735Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 Your team Zorba Coders is subscribed to branch lp:zorba. -- M

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-15 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Rejected => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 -- https://code.launchpad.net/~zorba-coders/zorba/add-archive-m

Re: [Zorba-coders] [Merge] lp:~davidagraf/zorba/fn_trace_jsoniq_fix into lp:zorba

2012-08-15 Thread David Graf
This query doesn't work because the serializer of the query result throws an error. The result of a query must not be an attribute. fn:trace does work on my side: ./bin/zorba -q 'trace(attribute { "a" } { 1 }, "a")' a [1]: a="1" <== fn:trace print serialization error [err:SENR0001]: "

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/add-archive-module into lp:zorba

2012-08-15 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/add-archive-module into lp:zorba has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~zorba-coders/zorba/add-archive-module/+merge/116086 -- https://code.launchpad.net/~zorba-coders/zorba/add-archi