Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
The last failing test is because Luis changed the constants back to all lower-case, but forgot to change the corresponding usage of those constants in a test case. However, as I just sent to zorba-dev, I personally believe all-caps is a better approach anyway, so I would like to change the modul

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
> One of the FOTS tests crashes We already pushed a fix for that one before asking for your re-review (it was an infinite loop eventually causing OOM). -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug-867376-2013-05-03T03-13-20.382Z is finished. The final st

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Matthias Brantner
One of the FOTS tests crashes Please see: http://zorbatest.lambda.nu:8080/cdash/testDetails.php?test=71145736&build=31952 On May 2, 2013, at 5:55 PM, Chris Hillery wrote: > I believe all outstanding comments have been addressed; Matthias, one more > pass, please? > -- > https://code.launchpad

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-867376-2013-05-03T03-13-20.382Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: htt

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Matthias Brantner
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Matthias Brantner
Review: Approve I have pushed some final documentation improvements. -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpa

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
I believe all outstanding comments have been addressed; Matthias, one more pass, please? -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-c

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Luis Rodriguez Gonzalez
> - Could you give an example in the documentation of uri:parse and show a > resulting URI object? Done > - The names of the variables are all upper-case. I know that we don't have any > coding conventions for it but the names in the full-text module are all lower- > case. Should we be consistent h

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230 -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merg

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue job fix_disputed_tc-2013-05-02T21-27-40.308Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot_May_2nd into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bump_FOTS_snapshot_May_2nd/+merge/162253 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpa

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bump_FOTS_snapshot_May_2nd into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/bump_FOTS_snapshot_May_2nd into lp:zorba. Commit message: - bumped FOTS snapshot to May 2nd - newly added test-case "fn-substring-31" passing - "FOAR0002-5" used to report 'wrongError' now passing after fixes in FOTS Requested review

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/fix_disputed_tc-2013-05-02T21-27-40.308Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230 -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread Cezar Andrei
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-1134008 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/1620

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Zorba Build Bot
Voting does not meet specified criteria. Required: Approve > 1, Disapprove < 1, Needs Fixing < 1, Pending < 1, Needs Information < 1, Resubmit < 1. Got: 1 Approve, 1 Pending. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 Your team Zorba Coders is subscribed to branc

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue job bug-1134008-2013-05-02T20-19-39.258Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-c

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-1134008-2013-05-02T20-19-39.258Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: h

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
The proposal to merge lp:~zorba-coders/zorba/bug-1134008 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/1620

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc_2/+merge/162233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zo

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/fix_disputed_tc_2 into lp:zorba. Commit message: - removed 3 test-cases marked as "disputed". Added new bug numbers from LP. Requested reviews: Paul J. Lucas (paul-lucas) Sorin Marian Nasoi (sorin.marian.nasoi) For more details,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_disputed_tc/+merge/162230 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba

2013-05-02 Thread Sorin Marian Nasoi
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/fix_disputed_tc into lp:zorba. Commit message: removed 2 test-cases marked as 'disputed' and opened a new LP bug Requested reviews: Cezar Andrei (cezar-andrei) Sorin Marian Nasoi (sorin.marian.nasoi) For more details, see: https

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Matthias Brantner
Review: Needs Fixing - Could you give an example in the documentation of uri:parse and show a resulting URI object? - The names of the variables are all upper-case. I know that we don't have any coding conventions for it but the names in the full-text module are all lower-case. Should we be con

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba

2013-05-02 Thread noreply
The proposal to merge lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980 -- https://code.launchpad.net/~zorba-coders/zorba/d

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue job deprecate-true_false_null-2013-05-02T09-50-53.505Z is finished. The final status was: All tests succeeded! -- https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: ht

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/deprecate-true_false_null-2013-05-02T09-50-53.505Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980 Your team Zorba Coders is subscribed to branch lp

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Zorba Build Bot
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Zorba Build Bot
The attempt to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba failed. Below is the output from the failed tests. CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:275 (message): Validation queue job bug-867376-2013-05-02T09-13-03.471Z is finished. The final st

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba

2013-05-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980 -- https://code.launchpad.net/~zorba-coders/z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/deprecate-true_false_null into lp:zorba

2013-05-02 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/deprecate-true_false_null/+merge/160980 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Zorba Build Bot
Validation queue starting for merge proposal. Log at: http://zorbatest.lambda.nu:8080/remotequeue/bug-867376-2013-05-02T09-13-03.471Z/log.html -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: htt

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been updated. Description changed to: - Fix for Bug 867376 URI processing module For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 -- https://code.launchpad.net/~zorba-coders/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been updated. Commit Message changed to: Added URI processing module. For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 -- https://code.launchpad.net/~zorba-coders/zorba/bug-8

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/util-jvm_core_module into lp:zorba

2013-05-02 Thread Chris Hillery
Did you have any other comments, Cezar? I want to think a bit about the ExternalModuleConfig.cmake that's included here; it looks like it might be redundant with the one in the Zorba trunk, plus I'm not sure it's the right solution to the problem anyway. -- https://code.launchpad.net/~zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
The proposal to merge lp:~zorba-coders/zorba/bug-867376 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867376 into lp:zorba

2013-05-02 Thread Chris Hillery
Review: Approve I believe Luis has addressed all concerns, and I have done some touch-ups as well. -- https://code.launchpad.net/~zorba-coders/zorba/bug-867376/+merge/159233 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Chris Hillery
Catalog002 needs to be marked as EXPECTED_FOTS_FAILURE. Also it and Catalog010 and Catalog011 can be associated with bug 1172273. After making that change, this can be merged. -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 Your team Zorba Coders is subscribed to bran

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1134008 into lp:zorba

2013-05-02 Thread Chris Hillery
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1134008/+merge/162000 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co