[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-23 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 -- https://code.launchpad.net/~zorba-coders/z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-23 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-09 Thread Till Westmann
Also it seems that the expected failures in the FOTS need to be updated. -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-09 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755 -- https://code.launchpad.net/~zorba-coders/z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1082740_fn_subsequence into lp:zorba

2013-04-09 Thread Till Westmann
Review: Needs Fixing Looks good, but I think that it would be nice to factor out the (virtual) calls to getDoubleValue(). Not sure if that's measurable, but I don't think that it hurts to give the compiler a hint :) -- https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+me

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-fix-internal-audit-constants into lp:zorba

2013-04-08 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/feature-fix-internal-audit-constants into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/feature-fix-internal-audit-constants/+merge/157676 -- https://code.launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-fix-internal-audit-constants into lp:zorba

2013-04-08 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-fix-internal-audit-constants/+merge/157676 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-fix-internal-audit-constants into lp:zorba

2013-04-08 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/feature-fix-internal-audit-constants into lp:zorba. Commit message: change name of generated constants to avoid conflicts Requested reviews: Till Westmann (tillw) Matthias Brantner (matthias-brantner) For more details, see: https

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-item_accessor into lp:zorba

2013-04-06 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-item_accessor into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-item_accessor/+merge/157491 -- https://code.launchpad.net/~zorba-coders/zorba/bug-item_ac

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-item_accessor into lp:zorba

2013-04-06 Thread Till Westmann
Review: Approve Interesting one :) -- https://code.launchpad.net/~zorba-coders/zorba/bug-item_accessor/+merge/157491 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba

2013-04-05 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975-fix-error-value/+merge/157489 -- https://code.launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba

2013-04-05 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975-fix-error-value/+merge/157489 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpa

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba

2013-04-05 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975-fix-error-value/+merge/157489 -- https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba

2013-04-05 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975-fix-error-value/+merge/157489 -- https://code.launchpad.net/~zorba-coders

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba

2013-04-05 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug1158975-fix-error-value into lp:zorba. Commit message: fix value for error message Requested reviews: Matthias Brantner (matthias-brantner) Related bugs: Bug #1158975 in Zorba: "errors casting to xs:dateTimeStamp&quo

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-gen_audit_props into lp:zorba

2013-04-03 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-gen_audit_props/+merge/156994 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-27 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/msb-misc into lp:zorba

2013-03-26 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/msb-misc/+merge/155656 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coder

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Description changed to: fixes for bug1158975 (xs:dateTimeStamp) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zor

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Commit Message changed to: fixes for bug1158975 (xs:dateTimeStamp) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-cod

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug1158975 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600 -- https://code.launchpad.net/~zorba-coders/zorba/bug1158975/+merge/155600

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1158975 into lp:zorba

2013-03-26 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug1158975 into lp:zorba. Requested reviews: Cezar Andrei (cezar-andrei) Related bugs: Bug #1158975 in Zorba: "errors casting to xs:dateTimeStamp" https://bugs.launchpad.net/zorba/+bug/1158975 For more details,

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/feature-empty_object into lp:zorba

2013-03-24 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/feature-empty_object/+merge/154989 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-module_null into lp:zorba/couchbase-module

2013-03-20 Thread Till Westmann
Review: Approve Looks good -- https://code.launchpad.net/~zorba-coders/zorba/couchbase-module_null/+merge/154570 Your team Zorba Coders is subscribed to branch lp:zorba/couchbase-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscr

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/oracle-nosql-db-module_null into lp:zorba/oracle-nosql-db-module

2013-03-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/oracle-nosql-db-module_null/+merge/154568 Your team Zorba Coders is subscribed to branch lp:zorba/oracle-nosql-db-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubs

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/oracle-nosql-db-module_null into lp:zorba/oracle-nosql-db-module

2013-03-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/oracle-nosql-db-module_null into lp:zorba/oracle-nosql-db-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/oracle-nosql-db-module_null/+merge/154568 -- https://code.la

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqllite-module_null into lp:zorba/sqlite-module

2013-03-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/sqllite-module_null into lp:zorba/sqlite-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/sqllite-module_null/+merge/154569 -- https://code.launchpad.net/~zorba-coders

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/sqllite-module_null into lp:zorba/sqlite-module

2013-03-20 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/sqllite-module_null/+merge/154569 Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://l

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/couchbase-module_null into lp:zorba/couchbase-module

2013-03-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/couchbase-module_null into lp:zorba/couchbase-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/couchbase-module_null/+merge/154570 -- https://code.launchpad.net/~zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2013-02-14 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1111487 into lp:zorba

2013-01-31 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-487/+merge/145868 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-collection_iteration into lp:zorba

2013-01-22 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/cleanup-collection_iteration into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/cleanup-collection_iteration/+merge/144369 -- https://code.launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/cleanup-collection_iteration into lp:zorba

2013-01-22 Thread Till Westmann
Review: Approve looks good and tests seem to work as well -- https://code.launchpad.net/~zorba-coders/zorba/cleanup-collection_iteration/+merge/144369 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.l

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-tab-cleanup into lp:zorba/security-module

2013-01-11 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/security-tab-cleanup into lp:zorba/security-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/security-tab-cleanup/+merge/142995 -- https://code.launchpad.net/~zorba-co

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/security-tab-cleanup into lp:zorba/security-module

2013-01-11 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/security-tab-cleanup/+merge/142995 Your team Zorba Coders is subscribed to branch lp:zorba/security-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https:

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug1058231 into lp:zorba

2012-11-26 Thread Till Westmann
> The removed/added problem is because Rodolfo initially deleted them, but then > put them back based on my earlier comment. Unfortunately I don't know of a > way to fix this. The way I usually solve this (if the history of the branch is not terribly relevant) is to create a patch from the branc

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/xml-in-json-indices into lp:zorba

2012-11-07 Thread Till Westmann
Review: Needs Fixing When running foaf-json-xml-index-point-maintenance.xq I run into a memory problem: ==13041== Invalid read of size 8 ==13041==at 0x5ED4C32: zorba::simplestore::CollectionTreeInfo::getCollection() const (collection_tree_info.h:54) ==13041==by 0x5EC3C45: zorba::simpl

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/more-numconversions into lp:zorba

2012-10-30 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/more-numconversions into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/more-numconversions/+merge/132208 -- https://code.launchpad.net/~zorba-coders/zorba/more-nu

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/more-numconversions into lp:zorba

2012-10-30 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/more-numconversions/+merge/132208 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/more-numconversions into lp:zorba

2012-10-30 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/more-numconversions into lp:zorba. Commit message: add to_xs_unsignedByte and to_xs_unsignedShort Requested reviews: Till Westmann (tillw) Matthias Brantner (matthias-brantner) For more details, see: https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867209 into lp:zorba

2012-10-23 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-867209 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-867209/+merge/131074 -- https://code.launchpad.net/~zorba-coders/zorba/bug-867209/+merge/131074

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-867209 into lp:zorba

2012-10-23 Thread Till Westmann
Review: Approve works for me :) -- https://code.launchpad.net/~zorba-coders/zorba/bug-867209/+merge/131074 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1039284 into lp:zorba

2012-10-22 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1039284 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677 -- https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/1296

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1039284 into lp:zorba

2012-10-22 Thread Till Westmann
Review: Approve Looks good - especially the name of the new source file :) -- https://code.launchpad.net/~zorba-coders/zorba/bug-1039284/+merge/129677 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/module-depends into lp:zorba

2012-10-22 Thread Till Westmann
Review: Approve Looks good to me. Added Chris as the master of all Zorba CMake files as a reviewer. -- https://code.launchpad.net/~zorba-coders/zorba/module-depends/+merge/130784 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 -- https://code.launchpad.net/~zorba-coders/zorba/bug-106

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1039284 into lp:zorba

2012-10-15 Thread Till Westmann
Review: Needs Fixing Looks good and works well. The only thing that should be fixed is the normalizeInput function. Since the same function is probably used for fn:doc, we should only have one implementation of this. I guess that "runtime/util" (or "runtime/misc"?) would be an appropriate loc

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Status: Approved => Needs review For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 -- https://code.launchpad.net/~zorba-coders/zorba/bug-106

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Description changed to: fix compilation without ZORBA_WITH_JSON For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 -- https://code.launchpad.net

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Commit Message changed to: fix compilation without ZORBA_WITH_JSON For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 -- https://code.launchpad.

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 -- https://code.launchpad.net/~zorba-coders/zorba/bug-106

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1067028-no-json/+merge/129743 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba

2012-10-15 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1067028-no-json into lp:zorba. Requested reviews: Till Westmann (tillw) Markos Zaharioudakis (markos-za) Related bugs: Bug #1067028 in Zorba: "compilation fails without ZORBA_WITH_JSON" https://bugs.launchpad.net/

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba/data-cleaning-module

2012-10-03 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba/data-cleaning-module has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/alternate-result-address-from-geocode/+merge/127797

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba/data-cleaning-module

2012-10-03 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/alternate-result-address-from-geocode/+merge/127797 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba/data-cleaning-module. -- Mailin

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba/data-cleaning-module

2012-10-03 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba/data-cleaning-module. Requested reviews: Zorba Coders (zorba-coders) For more details, see: https://code.launchpad.net/~zorba-coders/zorba/alternate-result-address-from-geocode

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba

2012-10-03 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/alternate-result-address-from-geocode/+merge/127792 Your team Zorba Coders is requested to review the proposed merge of lp:~zorba-coders/zorba/alternate-result-address-from-geocode into lp:zorba. -- Mailing list: https://launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes/+merge/126833 -- https://code.la

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes/+merge/126833 -- https://code.la

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes/+merge/126833 -- https://code.la

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-10-01 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-10-01 Thread Till Westmann
> Looks good, but there is a typo :-) (s/instauction/instruction). fixed. Thanks! -- https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Po

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba

2012-09-27 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes/+merge/126833 -- https://code.la

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba

2012-09-27 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes/+merge/126833 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba

2012-09-27 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1057792-serialize-nested-xdm-nodes into lp:zorba. Commit message: serialize nested XDM nodes as XML for the json-xml-hybrid method Requested reviews: Till Westmann (tillw) Ghislain Fourny (gislenius) Related bugs: Bug #1057792

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/prep-2.7 into lp:zorba

2012-09-27 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/prep-2.7 into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/prep-2.7/+merge/126810 -- https://code.launchpad.net/~zorba-coders/zorba/prep-2.7/+merge/126810 Your t

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/prep-2.7 into lp:zorba

2012-09-27 Thread Till Westmann
Review: Approve This changes everything. -- https://code.launchpad.net/~zorba-coders/zorba/prep-2.7/+merge/126810 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://la

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/prep-2.7 into lp:zorba

2012-09-27 Thread Till Westmann
Review: Needs Fixing "Exteneded" -> "Extended" -- https://code.launchpad.net/~zorba-coders/zorba/prep-2.7/+merge/126810 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : http

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-09-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-09-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-09-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip/+merge/126590 -- https://code.launch

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba

2012-09-26 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/bug-1055608-node-kinds-for-roundtrip into lp:zorba. Commit message: use XDM node kinds in encode-for-roundtrip Requested reviews: Matthias Brantner (matthias-brantner) Ghislain Fourny (gislenius) Related bugs: Bug #1055608 in Zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-26 Thread Till Westmann
> Thanks! Perhaps a test on non-valid JSON would be nice? Yes, they're in now. -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-error-code-fixes/+merge/126060 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorb

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-26 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-error-code-fixes/+merge/126060 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-25 Thread Till Westmann
> JNDY0040 does not exist in the spec. The error for parse-json if the supplied > string is not valid JSON or if there is more than one object/array when it's > forbidden, is JNDY0021. > > Does it make sense? Yes, it does. I've removed JNDY0040 completely and replaced references to it with JNDY0

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-25 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-error-code-fixes/+merge/126060 -- https://code.launchpad.net/~zorba-coders/zorba

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-25 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba has been updated. Description changed to: s/JNTY0003/JNTY0024/ s/JSDY0020/JNTY0020/ s/JSDY0021/JNDY0021/ removed JSDY0040 doc fixes for jn:parse-json For more details, see: https://code.launchpad.net/~zorba-coder

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-25 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba has been updated. Commit Message changed to: s/JNTY0003/JNTY0024/ s/JSDY0020/JNTY0020/ s/JSDY0021/JNDY0021/ removed JSDY0040 doc fixes for jn:parse-json For more details, see: https://code.launchpad.net/~zorba-co

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-24 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-error-code-fixes/+merge/126060 -- https://code.launchpad.net/~zorba-coders/zorba

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-24 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-error-code-fixes/+merge/126060 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.n

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba

2012-09-24 Thread Till Westmann
Till Westmann has proposed merging lp:~zorba-coders/zorba/jsoniq-error-code-fixes into lp:zorba. Commit message: s/JNTY0003/JNTY0024/ s/JSDY0040/JNDY0040/ s/JSDY0020/JNTY0020/ s/JSDY0021/JNDY0021/ doc fixes for jn:parse-json Requested reviews: Ghislain Fourny (gislenius) Till Westmann

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundt

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Till Westmann
> - JNTY0023 doesn't exist in the spec I've sent an e-mail to the list to add it to the spec. > - jn:decode-from-roundtrip should return item()*, e.g. it could also return > atomics > - Probably not related to this proposal but it's strange that the following > example doesn't raise a sequence-ty

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-21 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundt

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
> BTW: Why are the enum types so monstrously long? In this particular case, > Zorba_jsoniq_multiple_items_t can be replaced by a bool. Not sure. I agree that there are many ways in which this could be done differently. But I would like to keep the diff small so that it is easier to see what was

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
> s/Cannot/can not/ > > Please don't use Uppercase as you would a normal sentence. fixed -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to :

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundt

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundt

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba

2012-09-20 Thread Till Westmann
The proposal to merge lp:~zorba-coders/zorba/jsoniq-roundtrip into lp:zorba has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundtrip/+merge/124316 -- https://code.launchpad.net/~zorba-coders/zorba/jsoniq-roundt

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix-zorbaxquerycom into lp:zorba

2012-09-16 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix-zorbaxquerycom/+merge/124540 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~z

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/bug-1046561 into lp:zorba

2012-09-16 Thread Till Westmann
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/bug-1046561/+merge/123961 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-co

  1   2   3   >