Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255_image_module into lp:zorba/image-module

2012-05-16 Thread Sorin Marian Nasoi
> Sorry, this fix isn't right. > > 1. You can't depend on the relative path to the Zorba source directory, > because Zorba could be built with ZORBA_MODULES_DIR pointing anywhere. > > 2. You also can't depend on the build directory being a direct subdirectory of > the source directory. > > 3. Fi

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255_image_module into lp:zorba/image-module

2012-05-16 Thread Chris Hillery
Review: Needs Fixing Sorry, this fix isn't right. 1. You can't depend on the relative path to the Zorba source directory, because Zorba could be built with ZORBA_MODULES_DIR pointing anywhere. 2. You also can't depend on the build directory being a direct subdirectory of the source directory.

Re: [Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255_image_module into lp:zorba/image-module

2012-05-16 Thread Sorin Marian Nasoi
Review: Approve -- https://code.launchpad.net/~zorba-coders/zorba/fix_bug_962255_image_module/+merge/105991 Your team Zorba Coders is subscribed to branch lp:zorba/image-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : ht

[Zorba-coders] [Merge] lp:~zorba-coders/zorba/fix_bug_962255_image_module into lp:zorba/image-module

2012-05-16 Thread Sorin Marian Nasoi
Sorin Marian Nasoi has proposed merging lp:~zorba-coders/zorba/fix_bug_962255_image_module into lp:zorba/image-module. Requested reviews: Sorin Marian Nasoi (sorin.marian.nasoi) Chris Hillery (ceejatec) Related bugs: Bug #962255 in Zorba: "integrate into XQDoc the module dependency graph g