Juan, can you please make zorba-coders be the owner of this branch. I want to
make some changes to it, but I cannot because it currently belongs to you only.
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Done, just changed the ownership to zorba-coders
2011/11/1 Markos Zaharioudakis markos...@yahoo.com
Juan, can you please make zorba-coders be the owner of this branch. I want
to make some changes to it, but I cannot because it currently belongs to
you only.
--
The implementation of getExternalVariables in the xqueryimpl level is done.
Juan, I fixed the implementation of the XQuery::getExternalVariables() method.
The main problem there was that you were comparing QName items using their
string value. This is not correct because the string value of a
The implementation of getExternalVariables in the xqueryimpl level is done.
--
https://code.launchpad.net/~juan457/zorba/xqxq-api-changes/+merge/79589
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Ok, it looks better now, but we are not done yet
First, the comment in include/zorba/static_context.h for the
getExternalVariables() method is wrong. The method returns the qnames of all
the external variables that are in-scope within that static context. It's not
about whether the
Juan, the getExternalVariables method should be part of the static context, not
the dynamic context.
Probably the easiest way to implement this is to add an externalOnly param to
the static_context::getVariables method and then add a getExternalVariables
method in StaticContextImpl, which will
I added the test in the test/unit/cxx_api_changes.cpp just one question, what
you mena by mention my changes in ChangeLog, you mean in zorba/Changelog or did
I miss in bazaar something?
Juan, could you please also provide some tests? The best places would either
be
Review: Needs Fixing
Yes, the zorba/ChangeLog file should mention bug fixes and such extensions.
Also, the tests themselves look good but you should compare for the expected
result. For example, whether isSequential really returns true (instead of just
outputting it).
--
changes done
Yes, the zorba/ChangeLog file should mention bug fixes and such extensions.
Also, the tests themselves look good but you should compare for the expected
result. For example, whether isSequential really returns true (instead of just
outputting it).
--
Review: Needs Fixing
Juan, could you please also provide some tests? The best places would either be
doc/cxx/examples/context.cpp or test/unit/. Examples in the former file are
mostly used for documentation purposes because those examples are linked from
the web site. The latter directory
10 matches
Mail list logo
