Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Uns
The proposal to merge lp:~zorba-coders/zorba/bug-1189784 into
lp:zorba/sqlite-module has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Your team Zorba Cod
The proposal to merge lp:~zorba-coders/zorba/bug-1189784 into
lp:zorba/sqlite-module has been updated.
Commit Message changed to:
JSONiqfication for Sqlite Module Done!
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
--
https://code.launchpad.net
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Your team Zorba Coders is subscribed to branch lp:zorba/sqlite-module.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/67/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489 :
Votes: {'Approve': 1, 'Pending': 1, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Your team Zorba Coders is
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/bug-1189784/+merge/177489
Your team Zorba Cod
Review: Approve
Looks good - nice job!
I made three small changes:
1. Moved a in the metadata() doc to immediately after the leading sentence
of the comment.
2. Moved SqliteModule() constructor definition out-of-line.
3. Per mailing list discussion, marked a number of module functions as
no
Luis Rodriguez Gonzalez has proposed merging lp:~zorba-coders/zorba/bug-1189784
into lp:zorba/sqlite-module.
Requested reviews:
Luis Rodriguez Gonzalez (kuraru)
Chris Hillery (ceejatec)
Related bugs:
Bug #1189784 in Zorba: "Update non-core module "sqlite""
https://bugs.launchpad.net/zorba
10 matches
Mail list logo
