The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in src/store/naive/simple_pul.cpp
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-966706-2012-05-03T10-09-44.874Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-966706-2012-05-03T10-09-44.874Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in src/store/naive/simple_pul.cpp
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
This is ready for review again.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Approve
Looks good. I have disabled some debug output in rev. 10748.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/103835
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
Review: Approve
It would be nice to have 2 comments explaining
1) the modification of the parameter in simple_index_value.cpp:380 and 674 and
2) the role of key2 in Store::populateValueIndex.
It would also be nice to use the typedef here:
=== modified file 'src/store/naive/simple_pul.cpp'
---
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
It seems that automatic indexes are not maintained if a node is deleted. The
following example shows this:
library module:
module namespace seq = http://www.foo.com/default;;
I have fixed your test, but now I have a problem with test index/undo3.xq. Its
result is non-deterministic. Most of the time it returns the correct result,
but sometimes not. And valgrind does not show any errors :(
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your
I have implemented undo for incrementally maintained indexes.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-966706-2012-04-23T12-28-50.058Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 2 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Matthias Brantner has proposed merging lp:~zorba-coders/zorba/bug-966706 into
lp:zorba.
Requested reviews:
Markos Zaharioudakis (markos-za)
Till Westmann (tillw)
Related bugs:
Bug #966706 in Zorba: key uniqueness of value equality index not enforced
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Attempt to merge into lp:zorba failed due to conflicts:
text conflict in ChangeLog
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/bug-966706-2012-04-11T07-20-03.19Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Validation queue job bug-966706-2012-04-11T07-20-03.19Z is finished. The final
status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 3 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/bug-966706 into lp:zorba has been
updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Review: Needs Fixing
The problem is that now an index refresh must be undoable. I am looking at the
code to think wat is the best way to do the undo.
--
https://code.launchpad.net/~zorba-coders/zorba/bug-966706/+merge/101498
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing
34 matches
Mail list logo