The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-18T22-36-05.288Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
Review: Approve
Still looks good to me.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
Validation queue job feature-fetch_binary-2012-05-18T22-36-05.288Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 2 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-19T00-09-00.993Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
Validation queue job feature-fetch_binary-2012-05-19T00-09-00.993Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
--
https://code.launchpad.net/~zorba-coders/zorba/feature
Review: Approve
Looks good - even the transcoding stuff seems to work :)
Some remarks (nothing blocking):
- It would be nice to keep fetch-binary functions together in the module.
- Is internal::StreamResource::create ever used with 3 parameters?
- fetch_impl.cpp:
- 104
Why is
Looks good - even the transcoding stuff seems to work :)
Some remarks (nothing blocking):
- It would be nice to keep fetch-binary functions together in the module.
fixed
- Is internal::StreamResource::create ever used with 3 parameters?
for http stuff when coming from the api
-
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Chris Hillery (ceejatec)
Till Westmann (tillw)
For more details, see:
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Commit Message changed to:
- fetch:content-binary
- fetch:content#3 (with encoding parameter)
- StreamResource::isStreamSeekable to make sure the streamable strings returned
by fetch are seekable
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/106300
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Approve
Looks good except that the fetch module version should probably only be 2.1,
not 3.0. I'm voting Approve now, so if you don't re-submit the proposal (and
don't change anything else besides the version number) you should be able to
get it merged.
--
Looks good except that the fetch module version should probably only be 2.1,
not 3.0. I'm voting Approve now, so if you don't re-submit the proposal (and
don't change anything else besides the version number) you should be able to
get it merged.
I have changed the version 3.0 = 2.1 as
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Till Westmann (tillw)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
-
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Commit Message changed to:
- fetch:content-binary
- fetch:content#3 (with encoding parameter)
- StreamResource::isStreamSeekable to make sure the streamable strings returned
by fetch are seekable
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-11T15-47-14.061Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
Your team Zorba Coders is subscribed to branch lp:zorba.
Validation queue job feature-fetch_binary-2012-05-11T15-47-14.061Z is finished.
The final status was:
All tests succeeded!
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
Voting does not meet specified criteria. Required: Approve 1, Disapprove 1,
Needs Fixing 1, Pending 1. Got: 1 Approve, 1 Pending.
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list:
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105497
--
https://code.launchpad.net/~zorba-coders/zorba
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105359
- fetch:content-binary
-
The attempt to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-fetch_binary-2012-05-10T17-26-13.72Z
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105359
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105359
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-10T21-26-27.53Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105359
Your team Zorba Coders is subscribed to branch lp:zorba.
The attempt to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-fetch_binary-2012-05-10T21-26-27.53Z
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105359
--
https://code.launchpad.net/~zorba-coders/zorba
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Till Westmann (tillw)
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105430
-
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Commit Message changed to:
- fetch:content-binary
- fetch:content#3 (with encoding parameter)
- StreamResource::isStreamSeekable to make sure the streamable strings returned
by fetch are seekable
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105430
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105274
- fetch:content-binary
-
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Commit Message changed to:
- fetch:content-binary
- fetch:content#3 (with encoding parameter)
- StreamResource::isStreamSeekable to make sure the streamable strings returned
by fetch are seekable
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
- fetch:content-binary
-
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Commit Message changed to:
- fetch:content-binary
- fetch:content#3 (with encoding parameter)
- StreamResource::isStreamSeekable to make sure the streamable strings returned
by fetch are seekable
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-09T23-08-15.802Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
Your team Zorba Coders is subscribed to branch lp:zorba.
The attempt to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-fetch_binary-2012-05-09T23-08-15.802Z
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
--
https://code.launchpad.net/~zorba-coders/zorba
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-10T00-17-13.996Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
Your team Zorba Coders is subscribed to branch lp:zorba.
The attempt to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-fetch_binary-2012-05-10T00-17-13.996Z
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105275
--
https://code.launchpad.net/~zorba-coders/zorba
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
Till Westmann (tillw)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105290
-
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Commit Message changed to:
- fetch:content-binary
- fetch:content#3 (with encoding parameter)
- StreamResource::isStreamSeekable to make sure the streamable strings returned
by fetch are seekable
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105290
--
https://code.launchpad.net/~zorba-coders/zorba
Review: Approve
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105290
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe :
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-10T02-26-20.751Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105290
Your team Zorba Coders is subscribed to branch lp:zorba.
The attempt to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-fetch_binary-2012-05-10T02-26-20.751Z
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Approved = Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105290
--
https://code.launchpad.net/~zorba-coders/zorba
Matthias Brantner has proposed merging
lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba.
Requested reviews:
Matthias Brantner (matthias-brantner)
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105155
- fetch:content-binary
-
The proposal to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
has been updated.
Status: Needs review = Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105155
--
https://code.launchpad.net/~zorba-coders/zorba
Validation queue starting for merge proposal.
Log at:
http://zorbatest.lambda.nu:8080/remotequeue/feature-fetch_binary-2012-05-09T01-28-08.563Z/log.html
--
https://code.launchpad.net/~zorba-coders/zorba/feature-fetch_binary/+merge/105155
Your team Zorba Coders is subscribed to branch lp:zorba.
The attempt to merge lp:~zorba-coders/zorba/feature-fetch_binary into lp:zorba
failed. Below is the output from the failed tests.
CMake Error at /home/ceej/zo/testing/zorbatest/tester/TarmacLander.cmake:274
(message):
Validation queue job feature-fetch_binary-2012-05-09T01-28-08.563Z
62 matches
Mail list logo
