The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+m
Validation queue succeeded - proposal merged!
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Stage "CommitZorba" failed.
Check console output at http://jenkins.lambda.nu/job/CommitZorba/54/console to
view the results.
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-mod
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Commit Message changed to:
Added JSON HTTP client module.
Fixed initialization, error reporting and encoding bugs in the XML HTTP client.
Reimplemented XML HTTP client on top of the JSON HTTP client mod
Voting criteria failed for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579 :
Votes: {'Approve': 2, 'Needs commit message': 1}
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is sub
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-mod
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-mod
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Stage "TestZorbaUbuntu" failed.
158 tests failed (8414 total tests run).
Check test results at
http://jenkins.lambda.nu/job/TestZorbaUbuntu/114/testReport/ to view the
results.
--
https:/
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
The proposal to merge lp:~zorba-coders/zorba/json-http-module into lp:zorba has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-mod
Validation queue result for
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Stage "BuildZorbaUbuntu" failed.
Check compiler output at
http://jenkins.lambda.nu/job/BuildZorbaUbuntu/127/parsed_console to view the
results.
--
https://code.launchpad.net/~zorba-coders
Validation queue starting for the following merge proposals:
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Progress dashboard at http://jenkins.lambda.nu/view/ValidationQueue
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team
Review: Approve
Looks good, thanks!
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lists.launchpad.net
Unsubscribe : https:/
Chris, thanks for the comments.
I think I resolved all reported issues with the module.
The old http module is xquery only now.
I also did a cleaning pass over the cpp and removed two small initialization
bugs.
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your
>
> The old http-module when you send an http-request, specifying a non textual
> mime-type, the current http-client invokes the serializer specifiying the
> (unaccessible from XQuery code) "binary" method.
>
I meant
The old http-module when you send an http-request, specifying a non textual
mim
The old http-module when you send an http-request, specifying a non textual
mime-type, the current http-client invokes the serializer specifiying the
(unaccessible from XQuery code) "binary" method.
If the body is an xml node it gets converted in a very strange way:
there becomes "hello there"
> 1. OMG code duplication: the entire contents of http-client.xq.src is copied
> (and modified?) from the original http-client module. That's nearly 3000 lines
> of some of the ugliest and most error-filled code we've got. No way do we want
> to maintain two copies of it. Also, they both call curl_
Thank you for your feedback.
> 3. The module error codes need to be changed to match the coding guidelines:
> http://my.zorba.io/dokuwiki/doku.php?id=coding-guidelines#error_codes
I updated the error codes according to the guidelines
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-m
Review: Needs Fixing
1. OMG code duplication: the entire contents of http-client.xq.src is copied
(and modified?) from the original http-client module. That's nearly 3000 lines
of some of the ugliest and most error-filled code we've got. No way do we want
to maintain two copies of it. Also, the
Review: Approve
Checked the integer issue and is fixed also done more testing. Looks good.
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to :
I merged the trunk into the branch and added the ability to use hexbinary as a
body type.
Note that this required a further API extension beside in addtion to the
hexbinary stream which has been merged into the trunk a few hours ago.
Removed the jsoniq note from docs
--
https://code.launchpad.n
IMHO, it's not a good idea to have any notes in module docs about how to use
JSONiq. Virtually ask of our modules will have the same concerns, so we'd need
to duplicate it dozens of times. This isn't the appropriate location for that
information. I would take out that doc.
--
https://code.launc
>>> Cezar, it is not necessary for users to have a jsoniq version header in
>> their
>>> queries to use this module. They can use ("field") object accessors instead
>> of
>>> .field .
>>
>> My point was to mention these options somewhere in the doc and link to a page
>> which better describes this
> > Cezar, it is not necessary for users to have a jsoniq version header in
> their
> > queries to use this module. They can use ("field") object accessors instead
> of
> > .field .
>
> My point was to mention these options somewhere in the doc and link to a page
> which better describes this. IMH
> > Cezar, it is not necessary for users to have a jsoniq version header in
> their
> > queries to use this module. They can use ("field") object accessors instead
> of
> > .field .
>
> My point was to mention these options somewhere in the doc and link to a page
> which better describes this. IMH
> In the Doc examples use WWW.zorba.io... but the module is registered without
> WWW:
>
> xqDoc:
> import module namespace http="http://www.zorba.io/modules/http-client";;
> http:get("http://www.example.com";)
Fixed
> "timeout" option has a bug. Uncomment "timeout" in the following script and
>
> "timeout" option has a bug. Uncomment "timeout" in the following script and
> get this error:
>
> $ ./zorba -i -f -q q.jq
> error [zerr:ZSTR0040]: type error: Item::getIntValue() not defined for type
> "xs:integer"
>
>
> jsoniq version "1.0";
> import module namespace http="http://zorba.io/mod
> Cezar, it is not necessary for users to have a jsoniq version header in their
> queries to use this module. They can use ("field") object accessors instead of
> .field .
My point was to mention these options somewhere in the doc and link to a page
which better describes this. IMHO it's confusin
> Also, add a note on the module documentation section about using the header
> jsoniq version "1.0"; at the top and put a link to a page that describes this
> header.
Cezar, it is not necessary for users to have a jsoniq version header in their
queries to use this module. They can use ("field")
"timeout" option has a bug. Uncomment "timeout" in the following script and get
this error:
$ ./zorba -i -f -q q.jq
error [zerr:ZSTR0040]: type error: Item::getIntValue() not defined for type
"xs:integer"
jsoniq version "1.0";
import module namespace http="http://zorba.io/modules/http-client";
Review: Needs Fixing
Also, add a note on the module documentation section about using the header
jsoniq version "1.0"; at the top and put a link to a page that describes this
header.
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subsc
Review: Needs Fixing
In the Doc examples use WWW.zorba.io... but the module is registered without
WWW:
xqDoc:
import module namespace http="http://www.zorba.io/modules/http-client";;
http:get("http://www.example.com";)
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/16
Code looks good. I need a few more tests to make sure everything is fine.
--
https://code.launchpad.net/~zorba-coders/zorba/json-http-module/+merge/169579
Your team Zorba Coders is subscribed to branch lp:zorba.
--
Mailing list: https://launchpad.net/~zorba-coders
Post to : zorba-coders@lis
40 matches
Mail list logo
