Hi Max and Andrew,

Here are the updated webrevs for jdk_security2&3 test cleanup.

jdk_security2 --
http://cr.openjdk.java.net/~juh/7055362/webrev.7u.01/
Changes since last webrev:
 - changed to run in agentvm mode

jdk_security3 --
http://cr.openjdk.java.net/~juh/7055363/webrev.7u.01/
Changes since last webrev:
 - changed to run in agentvm mode
- even though it wasn't in the original jdk8 changeset, I had to edit test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CookieHandlerTest.java to force it to run in othervm mode because of the above change to the Makefile
 - moved the comment

 //
 // SunJSSE does not support dynamic system properties, no way to re-use
 // system properties in samevm/agentvm mode.
 //

   outside of the of @run tag in many ssl tests


I've re-tested both of these changesets.

Thanks,
Jason

On 09/12/2012 04:45 PM, Weijun Wang wrote:

jdk_security2 should use agenvm mode now.


I'll make this change.

Same with jdk_security3. I see no other problem.

Thanks
Max



7055363 -- jdk_security3 test target cleanup
Webrev: http://cr.openjdk.java.net/~juh/7055363/webrev.7u.00/
JDK8 Changeset: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/cb83fe13af98
CR: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7055363

Will take a look.

BTW, have you run the new test targets on JPRT?


Yes. For each of the changesets, the corresponding test targets ran
successfully. Is that sufficient?

Thanks,
Jason

Thanks
Max


Thanks,
Jason

Reply via email to