Looks fine to me. Xuelei
On 10/11/2012 9:55 AM, Weijun Wang wrote: > Ping again. > > Thanks > Max > > On 09/18/2012 05:26 PM, Weijun Wang wrote: >> First, I'm very glad to see that we are running manual tests. >> >> Then, please take a look at >> >> http://cr.openjdk.java.net/~weijun/7198507/webrev.00 >> >> Nothing is changed in the real keytool command calls, only some small >> changes: >> >> 1. Better prompt >> 2. Keystore file now /tmp/kkk.$$, clean and no conflict >> 3. Exit wherever a keytool command fails >> 4. Remove "export". It causes an error on Solaris >> 5. Add a "k" after "read". Only this can stop the process >> >> Thanks >> Max >> >> -------- Original Message -------- >> 7198507: [TEST_BUG] sun/security/tools/keytool/console.sh should be >> rewritten >> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7198507 >> >> === *Description* >> ============================================================ >> test have 2 problems: >> 1. It failed on solaris platforms due incorrect shell syntax >> 2. It should be interactive but one always shows "passed" status on >> linux and windows while really additional variables should be set by >> user before running for successful execution and user should decide >> passed test or failed. There are no any messages for user when test >> running under jtreg. >> >> >> solaris log: >> ----------System.out:(0/0)---------- >> ----------System.err:(1/244)*---------- >> /net/stt-13.ru.oracle.com/export2/stt/newroot/regression/workspaces/1.8.0/1.8.0_fcsb55/j2se/test/sun/security/tools/keytool/console.sh: >> >> PASS=\\303\\244\\303\\266\\303\\244\\303\\266\\303\\244\\303\\266\\303\\244\\303\\266: >> >> is not an identifier >> result: Failed. Execution failed: exit code 1 >> >> >> linux log: >> ----------System.err:(22/3266)---------- >> rm: cannot remove `kkk': No such file or directory >> /net/stt-13.ru.oracle.com/export2/stt/newroot/regression/workspaces/1.8.0/1.8.0_fcsb55/j2se/test/sun/security/tools/keytool/console.sh: >> >> line 66: /bin/keytool: No such file or directory >> .....
