John,

I looked at the changes that you have here:
   http://cr.openjdk.java.net/~chegar/8001579/webrev.01/

and it's great to get these warnings finally fixed.

The changes look okay to me and I assume that someone in the security group will sponsor this.

Two comments:

In Java_sun_security_jgss_wrapper_GSSLibStub_getMechPtr then I wonder if additional casts are needed for len as GetArrayLength returns a jsize and memcpy expects a size_t.

You might want to check with Vinnie on src/share/native/sun/security/ec/impl/mpi.c as there may be a desire to keep this code in sync with the upstream EC code

-Alan.

Reply via email to