I had left the regression test out of this as it was a typo rather than a code logic issue or something someone could rebroken. Are you ok if this goes back without a test?

Tony

On 03/28/2013 02:46 PM, Brad Wetmore wrote:
There is no regression test.  I created one which relies on reflection,
which is one way to test this problem.  Feel free to create another, but
that one is ready to go.

Please see the attachment in the bug, and you'll probably want to update
the copyright date.

Brad



On 3/28/2013 2:29 PM, Anthony Scarpino wrote:
Hi all,

I have a very simple code review request.  It's a typo bug.

8001596 Incorrect condition check in PBKDF2KeyImpl.JAVA
https://jbs.oracle.com/bugs/browse/JDK-8001596

http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/8001596/webrev.01/

thanks

Tony

Reply via email to