Looks good.
brad
On 10/17/2013 11:35 AM, Vincent Ryan wrote:
Looks fine.
Thanks.
On 17 Oct 2013, at 19:04, Jason Uh wrote:
Hi Vinnie, I'd like to add to this changeset to ensure that resources are
closed. Could you please review the revision?
http://cr.openjdk.java.net/~juh/8026233/webrev.01/
Thanks,
Jason
On 10/10/2013 12:15 PM, Vincent Ryan wrote:
That fix looks fine Jason.
Thanks.
On 10 Oct 2013, at 01:57, Jason Uh wrote:
Hi Vinnie,
Could you please review this fix? The test
sun/security/tools/keytool/StorePasswords.java can terminate with an error on
Windows because of files not getting cleaned up, so this fix deletes the
keystore file at the end of the test.
webrev: http://cr.openjdk.java.net/~juh/8026233/webrev.00/
Thanks,
Jason
