Looks fine to me.

I was wondering, whether it is a little bit more instinctive to return a
string with the type number for "unknown" and "private" algorithm in
KerberosKey.getAlgorithm().  For example:

    "unknown" -> "kid-2014"
    "private" -> "kid-(2014)"

Thanks,
Xuelei

On 4/8/2014 10:37 AM, Weijun Wang wrote:
> Hi All
> 
> Please review the code changes at
> 
>    http://cr.openjdk.java.net/~weijun/8035986/webrev.00/
> 
> It's about using IANA names in KerberosKey instead of old non-standard
> names.
> 
> Thanks
> Max

Reply via email to