On 06/18/2014 05:59 AM, Vincent Ryan wrote:
Thanks Sean.

Our existing PKCS11 tests are sufficient as regression tests so I’ve added 
’noreg-self’.
Also, I didn’t set a subcomponent value as only the PKCS11 testsuite has 
changed not
the PKCS11 implementation.

Hmm. I've always considered the subcomponent to also apply to the package or area a test is testing.

--Sean


On 17 Jun 2014, at 19:55, Sean Mullan <sean.mul...@oracle.com> wrote:

The bug needs a noreg label. Also the subcomponent should probably be 
javax.crypto:pkcs11. Otherwise looks fine to me.

--Sean

On 06/17/2014 02:41 PM, Vincent Ryan wrote:
Please review the following changeset to refresh the version of NSS that is 
included with
the PKCS11 test suite.

The old version of NSS 3.13.1 is replaced with NSS 3.16 which has been built 
with VS2010
on Windows 32-bit and 64-bit. This corrects an intermittent failure with PKCS11 
tests on Windows.

Thanks.

Bug: https://bugs.openjdk.java.net/browse/JDK-8047085
Webrev: http://cr.openjdk.java.net/~vinnie/8047085/webrev.00/


Reply via email to