Looks good, just one comment in GssKrb5Base - I would change
getNegotiatedProperty to call the superclass method first, and then if
that returns null, check for the gss inquiretype properties. This way
you don't check for IllegalStateExc twice, and it seems cleaner to me.
Also, please add a release notes label so that this is documented in the
release notes, and open a separate docs bug to add a section to the SASL
Reference Guide to more fully describe these new properties and how to
use them.
Thanks,
Sean
On 07/03/2014 10:30 PM, Wang Weijun wrote:
Hi All
Please review the code change at
http://cr.openjdk.java.net/~weijun/8044085/webrev.00
With this change, all existing (and future) InquireType values for
ExtendedGSSContext.inquireSecContext() are available to the SASL GSSAPI
mechanism as negotiated properties.
Code change is in GssKrb5Base.java. Clarification in spec of
getNegotiatedProperty() in SaslClient and SaslServer. New lines in an existing
test for sanity check.
Thanks
Max
