Can someone please help reviewing this following fix?
https://bugs.openjdk.java.net/browse/JDK-8049312
Webrev: http://cr.openjdk.java.net/~valeriep/8049312/webrev.00/

The must-fix change is in || src/share/classes/com/sun/crypto/provider/CipherCore.java which is to correct the data size calculation based on "unitBytes". For example, for CFB24, our current impl assumes the given data will be multiples of 3 bytes. When the given data isn't multiples of 3, it will continue but then the result is incorrect.

To make the code more robust, I think we should explicitly check and error out when the given data doesn't have the correct size. Thus, I have added the input-length check to the various mode implementations. Along the way, I also fixed javadoc typos, removed redundancies, etc.

Thanks,
Valerie

Reply via email to