Looks fine to me.
--Sean
On 08/19/2014 10:59 PM, Wang Weijun wrote:
Please review the fix for the same bug for jdk8u-dev:
http://cr.openjdk.java.net/~weijun/8054817/8u/webrev.00/
We don't have sun.misc.VM.getuid() in jdk8 so the fix is even simpler. The test
is identical though.
Thanks
Max
On Aug 11, 2014, at 22:14, Wang Weijun <weijun.w...@oracle.com> wrote:
Please review the fix at
http://cr.openjdk.java.net/~weijun/8054817/webrev.00
since we have a new getuid() now for all Unix systems.
It does return -1 on Windows, but I keep the osname.startsWith("Windows") check
to be exactly consistent with the current behavior. getuid() might return something not
-1 one day on Windows.
Thanks
Max
