Hi Sean,
Thank you for reviewing this. I have improved codes by your suggestions.
New webrev link:
http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.02/
Thanks,
Amanda
On 8/19/14 10:13 AM, Sean Mullan wrote:
On 08/06/2014 06:25 PM, Amanda Jiang wrote:
Sorry, wrong webrev link, it should be:
http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.01/
Mostly looks good, just a few comments:
* NullPerms
I suggest renaming this test to LimitedDoPrivilegedWithNullPerms
[27-28] Suggest rewording as: "Test that NullPointerException is
thrown if any element of perms parameter is null"
- you should add a couple of tests with PrivilegedActionException as
the first parameter (1 for doPrivileged and 1 for
doPrivilegedWithCombiner).
* LimitedDoPrivilegedWithThread
[27] typo: s/trhead/thread/
--Sean
Thanks,
Amanda
On 8/6/14 3:24 PM, Amanda Jiang wrote:
Updated the original codes for better handling interrupted exception.
webrev: http://cr.openjdk.java.net/~tyan/amandaj/JDK-8031661/webrev.01/
Thanks,
Amanda
On 7/30/14 4:50 PM, Amanda Jiang wrote:
Hi All,
Could you please review following 2 new regression tests to be added
for JEP140 (Limied doPrivileged).
New tests are added to perform permission tests for limited
doprivileged with multiple threads , and basic API testing.
JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8050281
webrev: http://cr.openjdk.java.net/~rhalade/8050281/webrev.00/
Thanks,
Amanda
