I see no problem from the core part of the webrev. However, I am not sure how you find all the occurrences of "+" in StringBuilder, but I just run the following command in jdk/src
find . -type f -name *.java -print | xargs grep -n StringBuilder | perl -ne 'print if /new StringBuilder\([^\)]*\+/' find . -type f -name *.java -print | xargs grep -n append | perl -ne 'print if /append\([^\)]*\+/' and there are still many results. Some are false alarms like buf.append(" + "); result.append(patt.charAt(i + 1)); but I still see sb.append("Extension unknown: " + "DER encoded OCTET string =\n") StringBuilder sb = new StringBuilder("\"" + ti.getThreadName() + "\"" + tagBuffer.append("<tr bgcolor=\""+ color[selColorIndex] + "\">"); ... Thanks Max On Aug 26, 2014, at 11:28, Wang Weijun <weijun.w...@oracle.com> wrote: > New webrevs available at > > http://cr.openjdk.java.net/~weijun/8055723/client/webrev.01/ > http://cr.openjdk.java.net/~weijun/8055723/core/webrev.01/ > > There are only 2 now. Everything non-client is in core. > > Everyone, please do code review quickly because the patch touches too many > files and any delay could mean re-merge. > > *Otávio*: If there is only small change in feedback, tell me to update my own > repo and you don't need to generate the big patch again. > > I see you still include that demo file. > > Thanks > Max > >