Re: [JDK-9] RFR: JDK-8048617: Tests for PKCS12 read operations

[zaiyao liu]

Hi Max,

Thanks for catching that, please review again: 
http://cr.openjdk.java.net/~tyan/kevin/JDK-8048617/webrev02/

Thanks

Kevin
于 2014/8/25 15:31, Wang Weijun 写道:
Several comments:

1. openjdk does not like binary files. I would store them in BASE64.

2. You can store a certificate in pkcs12 keystore now, so block at line 153 is 
not correct anymore for all pkcs12 keystores. Of course, you can keep it 
because all your testing pkcs12 stores should only contain key pair entries, 
but remember to add a comment.

3. Why now just list all files in that directory and call readTest() on each? 
That will save you a lot of @run lines. Or, is there an exception?

Thanks
Max


On Aug 25, 2014, at 15:18, zaiyao liu <zaiyao....@oracle.com> wrote:

Hi Xuelei,

May I request you to review 1 new test to be added for PKCS12 read operations. 
New test are added to address following:
  - Implement tests for read operations with PKCS12 keystore.

JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048617
Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048617/webrev01/

Thanks,
     
Kevin