Looks fine to me. Thanks, Xuelei
On 9/3/2014 10:57 AM, zaiyao liu wrote: > Hi Xuelei, > > Thanks for review, please review the update: > http://cr.openjdk.java.net/~tyan/kevin/JDK-8048621/webrev02/ > > Thanks > > Kevin > 于 2014/9/1 17:42, Xuelei Fan 写道: >> Providers.java >> --------------- >> May be not necessary to define Providers.SUN_JCE, >> Providers.SUNPKCS11_SOLARIS. As add unnecessary dependencies among >> tests, and slow down the test performance. >> >> TestKeyStoreBasic.java >> ---------------------- >> Better to throw exception, rather than return false so that the cause of >> failure is exposed in the exception stacks. >> >> TestKeyStoreEntry.java >> ---------------------- >> See above. >> >> A question: in which case PKCS11 keystore is disabled? >> >> Xuelei >> >> >> On 9/1/2014 3:14 PM, zaiyao liu wrote: >>> Hi Xuelei, >>> >>> Can you help to review those tests? >>> >>> Thanks >>> >>> Kevin >>> 于 2014/8/28 9:45, zaiyao liu 写道: >>>> Hi All, >>>> >>>> Please review the code change,the purpose of this fix is implement >>>> basic tests for keystore types supported by JDK. >>>> >>>> Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048621/webrev01/ >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8048621 >>>> >>>> Thanks >>>> >>>> Kevin >
