On 29/09/2014 20:14, Wang Weijun wrote:
Hi All

Please review the code change at

    http://cr.openjdk.java.net/~weijun/8058657/webrev.00/

It includes both the dev repo and dev/jdk repo. While the change in dev/jdk is 
useless with today's modules environment, it is included here and will be 
backported into jdk8u.

This looks okay except for the first statement in the renamed package-info. It might read a bit better if you drop the first statement and have the second start with "This package comprises the interfaces ...". Otherwise the changes look good to me. Once we have the module system in JDK 9 then we can drop @jdk.Exported.

-Alan

Reply via email to