Looks fine to me.
--Sean
On 10/28/2014 02:42 PM, Vincent Ryan wrote:
OK thanks. I had been looking for your name in that list.
In addition, changesets require a testcase to verify the fix so I've
modified an existing keychain testcase.
I’ve updated the previous webrev, in place:
http://cr.openjdk.java.net/~vinnie/8062264/webrev.00/
On 28 Oct 2014, at 11:12, Florian Bruckner (3kraft)
<florian.bruck...@3kraft.com <mailto:florian.bruck...@3kraft.com>> wrote:
Hi Vincent,
the webrev looks good.
I have also received confirmation that the OCA was approved - looking
at the address you mentioned, it is listed with the company name
"3kraft IT GmbH & Co KG".
regards,
Florian
On 28.10.14 11:50, Vincent Ryan wrote:
No problem. I made a slight modification to your fix to replace the
fixed password with a randomly generated one.
Here’s the webrev:
http://cr.openjdk.java.net/~vinnie/8062264/webrev.00/
<http://cr.openjdk.java.net/%7Evinnie/8062264/webrev.00/>
If you’re OK with that then I’ll push your fix along with two other
fixes to KeychainStore.
BTW OCA approval is required before your patch can be integrated and
I don’t see your name listed at:
http://www.oracle.com/technetwork/community/oca-486395.html
Did you receive a confirmation email?
