Max,
Most looks fine, just some questions.
- Kinit.java: line 56, it should be
"sun.security.krb5.internal.tools.Kinit"?
- Kinit.java: for the switch block from 135 - 142: add a default case to
catch illegal values?
- Kinit.java: line 163, doesn't the credentials cache exist already?
- KrbAsReq.java: line 128, what if rtime is 0 (default value)?
- KDC.java: line 879-883, how can you be sure that there is always more
than 1 eType and that the 2nd eType is supported.
Valerie
On 11/6/2014 10:31 AM, Valerie Peng wrote:
OK, I will take a look.
Thanks,
Valerie
On 11/5/2014 10:04 PM, Wang Weijun wrote:
Ping ping...
On Oct 20, 2014, at 13:22, Wang Weijun<weijun.w...@oracle.com> wrote:
Anyone can take a look?
On Sep 25, 2014, at 18:54, Wang Weijun<weijun.w...@oracle.com> wrote:
Hi All
Please review the code change at
http://cr.openjdk.java.net/~weijun/8044500/webrev.00
It adds support for ticket_lifetime and renew_lifetime in
krb5.conf, and add -r -l -R to kinit (on Windows).
Thanks
Max
