Thanks, I'll push after I remove that comment.
Jason
On 01/09/2015 10:50 AM, Sean Mullan wrote:
On 01/08/2015 09:46 PM, Jason Uh wrote:
Thanks, Sean.
Here is an updated webrev with your suggested changes. I've also added
tests here, and will no longer be adding tests for this changeset to the
closed repo.
http://cr.openjdk.java.net/~juh/8046724/01/
Looks good, just one minor comment. Can you remove the comment on line
169 of KeySelectors.java? It is no longer true now that all 3 key types
are supported.
Thanks,
Sean
Thanks,
Jason
On 12/18/2014 07:02 AM, Sean Mullan wrote:
Just a few comments:
- some of the methods (encodePoint, trimZeroes, ...) can be made private
static.
451: if getCurveOid returns null, you should throw MarshalException
instead of outputting a null Oid
486: if getECParameterSpec returns null, you should throw
MarshalException (otherwise an NPE would be thrown on line 498)
520,524: these methods should be private
--Sean
On 12/16/2014 02:44 PM, Jason Uh wrote:
Please review this fix, which allows XML Signature ECKeyValue elements
to be marshalled and unmarshalled.
Dependence on internal sun.security.* classes has been removed, so that
the (un)marshalling can happen without reflection.
webrev: http://cr.openjdk.java.net/~juh/8046724/00/
bug: https://bugs.openjdk.java.net/browse/JDK-8046724
A corresponding test will be added to the closed repository.
Thanks,
Jason
