Thanks Max,
please review the update:
http://cr.openjdk.java.net/~zailiu/8048610/webrev.01/webrev/
Kevin
在 2015/3/4 13:52, Weijun Wang 写道:
Empty:
- 29: I am not a fan of import static using like this, but you are
free to do anyway
- 34: "with expected message". You didn't check if the message is
expected, you only check if it's empty
- 39, 41, 43, 51: left brace should go back to previous lines
- line 48 and 49 can be fit in one line, throw -> thrown
- 45: space after comma
- 47: no space before right parenthesis
- 50: space before catch
- 53: space after if
- 57: InvalidKeyException is thrown
bug4901658:
- 69, 70: indent
- 75: "has been encoded with", space after comma
- 78: no need to try-with-resources, byte stream has no close
- 85: what for?
- 87,93: what is tmp for?
- 89,98: what is toString() for? You want a hex dump?
- 99: We normally write "if (!"
--Max
On 2/16/2015 9:35, zaiyao liu wrote:
Hi all,
Please help to review those 2 new tests to verify following 2 JDK bug
fixes in JCE:
- JDK-4686632: InvalidKeyException.getMessage() returns null
- JDK-4901658: Can not produce a string from key's encoded byte[]
consistently
JDK issue: https://bugs.openjdk.java.net/browse/JDK-8048610
Webrev: http://cr.openjdk.java.net/~zailiu/8048610/webrev/
Thanks
Kevin
