Looks fine. One small issue: LEAD_CERT does not have a "\n" before the "-----END" line. Although X509Factory accepts it this is not correct.
--Max > On Mar 19, 2015, at 14:04, zaiyao liu <zaiyao....@oracle.com> wrote: > > Hi Max, > > Thanks for review, > please check the update: > http://cr.openjdk.java.net/~zailiu/8048618/webrev01/test/java/security/KeyStore/PKCS12/WriteP12Test.java.html > > Thanks again. > Kevin > 在 2015/3/18 14:23, Wang Weijun 写道: >> >> 33 * WriteP12CertChainBad: same as WriteP12CertChain but chains order is >> 34 * user-ca-lead, the order is wrong so expects to fail. >> >> Really? What is the exception? > this line will catch the exception. > > 167 } catch (KeyStoreException e) { > >> Another suggestion, please move the text in the summary before the actual >> codes inside main() as comments. It's hard to page up and page down to find >> out what the tests are doing. > Fixed, thanks. >> Thanks >> Max >> >> >>> On Mar 18, 2015, at 13:33, zaiyao liu<zaiyao....@oracle.com> wrote: >>> >>> Hi Max, >>> >>> Please help to review this test: >>> >>> JDK issue:https://bugs.openjdk.java.net/browse/JDK-8048618 >>> Webrev:http://cr.openjdk.java.net/~zailiu/8048618/webrev/ >>> >>> Thanks >>> >>> Kevin >
