> On 20 May 2015, at 10:59, Weijun Wang <[email protected]> wrote: > > The code change looks fine. Thanks.
> > If it were me, I won't do any clean up. Previously there were some problems with cleanup on Windows. If that cleanup code is no longer necessary I’ll remove it. > > --Max > > On 5/14/2015 11:14 PM, Vincent Ryan wrote: >> That makes more sense. I’ve updated the webrev in place. >> >> >>> On 14 May 2015, at 15:29, Weijun Wang <[email protected]> wrote: >>> >>> Hi Vinnie >>> >>> Is there any reason why they cannot be simply created in the current >>> directory? >>> >>> In fact, if you put them there, then you don't need to clean them up >>> because jtreg will do that for you. If the test fails some day, they will >>> be retained for your diagnostics. >>> >>> Thanks >>> Max >>> >>> On 5/13/2015 11:52 PM, Vincent Ryan wrote: >>>> Please review this test correction to avoid creating temporary keystore >>>> files in the test source directory. >>>> Thanks. >>>> >>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8072578 >>>> Webrev: http://cr.openjdk.java.net/~vinnie/8072578/webrev.00/ >>>> >>>> >>
