Your fix looks good. Thanks Max.
> On 23 Jun 2015, at 07:34, Weijun Wang <[email protected]> wrote:
>
> Hi Michael
>
> Webrev updated at
>
> http://cr.openjdk.java.net/~weijun/8023546/webrev.01
>
> I added a check about the extra sign byte, I even added a null check in
> KeyStore.java, although if the fix is done right they should never happen.
>
> The return value of the convertToLittleEndian() function is now always
> destinationLength. This was also the value before the fix, which is the
> number of bytes we actually write, including zeroes.
>
> Personally I'm still a little afraid of --x (and x++, if it's used in an
> expression), so I kept the old style.
>
> Can anyone with a reviewer badge also look at this?
>
> Thanks
> Max
>
