Looks fine to me. Xuelei
On 7/20/2015 2:03 PM, Weijun Wang wrote: > Ping again. > > Also, this change is needed inside jdk9/dev: > > diff --git a/modules.xml b/modules.xml > --- a/modules.xml > +++ b/modules.xml > @@ -1777,6 +1777,11 @@ > <name>jdk.policytool</name> > <depend>java.base</depend> > <depend>java.desktop</depend> > + <depend>java.logging</depend> > + <depend>java.management</depend> > + <depend>java.security.jgss</depend> > + <depend>java.sql</depend> > + <depend>jdk.security.jgss</depend> > </module> > <module> > <name>jdk.rmic</name> > > Thanks > Max > > On 07/18/2015 08:26 AM, Weijun Wang wrote: >> A new version at >> >> http://cr.openjdk.java.net/~weijun/8131350/webrev.01/ >> >> "public" modifiers of methods/fields inside Prin/Perm and child classes >> removed. >> >> Thanks >> Max >> >> On 07/16/2015 09:43 PM, Weijun Wang wrote: >>> Hi All >>> >>> Please take a look at >>> >>> http://cr.openjdk.java.net/~weijun/8131350/webrev.00/ >>> >>> Policytool contains a lot of hard coded strings for permission class >>> names, which can be changed to actual Class types. That allows checking >>> at compile-time rather than failing at run-time if any name had a typo. >>> >>> Noreg-cleanup. >>> >>> Thanks >>> Max
