I might also suggest grabbing a byte from the various implementations to ensure they return working implementations.

You should also include a comment which mentions that this is an implementation-specific test for the Oracle & stock OpenJDK implementations, and that other implementations might use other SecureRandom implementations in which case this test would need to be adjusted.

Does that make sense?

Brad


On 9/4/2015 1:43 PM, Rajan Halade wrote:
Please help with your review of this new test to check default provider
used with SecureRandom.

Bug: https://bugs.openjdk.java.net/browse/JDK-8048356
Webrev: http://cr.openjdk.java.net/~rhalade/8048356/webrev.00/

Thanks,
Rajan

Reply via email to