On 10/15/2015 11:42 AM, Valerie Peng wrote:
<MakeJavaSecurity.java> - line 58-59, the "[openjdk target cpu architecture]" one should be moved up. The optional restricted packages file names are at the end.
Ah yes.. of course..
<General> - for the javadoc changes, the approved CCC has @implNote instead of @implSpec.
Sigh.. I must have cut-n-pasted the earlier version of the CCC..
Instead of just {@code getProviders}, it seems {@code
Security.getProviders} is clearer.
If I can change it without getting CCC approval, I will. If not, then it will remain this way.
<XMLSignatureFactory.java> - line 262 - 267, given that there is an argument specifying provider name, I don't think your changes applies to this method. If correct, the javadoc change should be removed.
I must of pasted it their by mistake. It's not in the CCC either.
<java.security> - looks fine. I will continue to look at ProviderList.java and send u comments in a separate email. Thanks, Valerie On 10/9/2015 10:06 AM, Anthony Scarpino wrote:Ping for a security review.. Tony On 10/02/2015 10:08 AM, Anthony Scarpino wrote:Hi all, I'm need a review of the last developement piece to JEP 246, the configuration changes. I've copied the build-dev in case there were any comments on the minor changes in the make directory related to the java.security file. http://cr.openjdk.java.net/~ascarpino/8133151/webrev/ thanks Tony
