Looks fine to me. Thanks, Xuelei
On 5/20/2016 9:49 AM, Artem Smotrakov wrote: > I added more output for debugging intermittent failures in > https://bugs.openjdk.java.net/browse/JDK-8132320 > > I also updated produceHandshakePackets() to handle NEED_UNWRAP_AGAIN. > > http://cr.openjdk.java.net/~asmotrak/8129389/webrev.01/ > > Artem > > On 05/18/2016 08:28 PM, Artem Smotrakov wrote: >> Hello, >> >> Please review the following patch for DTLS tests. >> >> A couple of DTLS tests which are based on DTLSOverDatagram.java fail >> intermittently. I was not able to reproduce these failures. I am >> proposing to update the tests to print more information to logs, so >> that more information will be available if they fail next time. >> >> I also noticed that the tests doesn't check for FINISHED handshake >> status which can be returned by wrap/unwrap methods. This status >> should indicate that handshake finished. >> >> Changes: >> - enabled debug output by setting "javax.net.debug" system property to >> "ssl" >> - added more logging to handshaking code >> - updated handshaking code to check for FINISHED status >> - added more checks to handshaking code >> - added try-with-resources blocks for sockets and file input streams >> - removed suppressed exceptions to make logs clearer >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8129389 >> Webrev: http://cr.openjdk.java.net/~asmotrak/8129389/webrev.00/ >> >> Artem >
