Looks fine to me. Thanks! Xuelei
> On Jun 7, 2016, at 2:45 PM, Sibabrata Sahoo <sibabrata.sa...@oracle.com> > wrote: > > Hi Xuelei, > > Please find the updated webrev: > http://cr.openjdk.java.net/~ssahoo/8157896/webrev.01/ > > As suggested, I have increased the timeout for (3072 256) to 700. > > Thanks, > Siba > > -----Original Message----- > From: Xuelei Fan > Sent: Saturday, June 04, 2016 6:02 AM > To: Sibabrata Sahoo; Valerie Peng; security-dev@openjdk.java.net > Subject: Re: [9] RFR: 8157896: TestDSAGenParameterSpec.java test fails with > timeout > > SupportedDSAParamGen.java > ========================= > Please use more large timeout. The update from 450 to 550 may be not > significant enough to prevent intermittent failure. I may use bigger value, > 600 or even bigger? > > The same comment for TestDSAGenParameterSpec.java. > > Thanks, > Xuelei > > >> On 5/31/2016 11:04 PM, Sibabrata Sahoo wrote: >> Hi, >> >> >> >> Please review the fix for the following JBS bugs, >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8157896 >> >> https://bugs.openjdk.java.net/browse/JDK-8157898 >> >> >> >> webrev: http://cr.openjdk.java.net/~ssahoo/8157896/webrev.00/ >> >> >> >> Description: >> >> These Tests takes a lots of time to generate DSA parameter when the >> prime and subprime values are greater in some machine with some >> platform. The reason is being the operations are CPU intensive, which >> causes the Tests to timeout in rare occasion. But the Test performance >> can be improved by, instead of generating DSA parameter with all >> supported input in a single run, it can be divided for each input as a >> separate run, so that each run can complete much before compared to >> all input at once. It also provides the flexibility to associate test >> options like "timeout" for specific input type where the execution >> time is expected to exceed the default. >> >> >> >> Note: The fix won't give a guarantee that the timeout will never >> happen but it can surely help reduce the timeout in greater extent. >> Please provide your suggestion, in case any. >> >> >> >> >> >> Thanks, >> >> Siba >
