Nice catch! Looks fine to me. Thanks, Xuelei
On 6/21/2016 4:46 AM, Artem Smotrakov wrote: > Hello, > > Please review this patch for SSLSocketSSLEngineTemplate.java test. > > The test fails intermittently with "Unexpected EOF" error. Please see > Brad's comment which explains the issue > > https://bugs.openjdk.java.net/browse/JDK-8049314?focusedCommentId=13519136&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13519136 > > > Calling compact() method before continuing (as Brad suggested) seems to > solve the issue. The patch also updates the test to use a > try-with-resource block while reading keystores. > > sun/security/ssl/SSLEngineImpl/SSLEngineBadBufferArrayAccess.java test > doesn't seems to be affected because it always calls compact() after > flip(). > > Webrev: http://cr.openjdk.java.net/~asmotrak/8049314/webrev.00/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8049314 > > Artem
