Looks good. Approved for jdk8u-dev. Please add a suitable noreg- label
to the bug report.
Regards,
Sean.
On 24/06/16 12:48, Svetlana Nikandrova wrote:
Sean,
thank you for spotting this "multiple of 64". Please see updated weberv:
http://cr.openjdk.java.net/~snikandrova/8147969/webrev.01/
<http://cr.openjdk.java.net/%7Esnikandrova/8147969/webrev.01/>
Thank you for your reminder. Surely, I have signed sunjce_provider.jar
and sunpkcs11.jar in my pocket (I believe changes in
ServerHandshaker.java should not affect them, so I don't need a new
version because of that).
Thank you,
Svetlana
On 24.06.2016 9:59, Seán Coffey wrote:
src/share/classes/sun/security/ssl/ServerHandshaker.java :
! "Unsupported customized DH key size: " +
! customizedDHKeySize + ". " +
! "The key size must be multiple of 64, " +
! "and can only range from 1024 to 2048
(inclusive)");
You can remove the "multiple of 64" text. That condition was only
introduced into JDK 9 from what I read.
Looks good otherwise. Don't forget to get new signed jar files
generated when integrating.
Regards,
Sean.
On 23/06/2016 19:20, Svetlana Nikandrova wrote:
Hello,
could you please review and approve this supportability fix for
JDK-8147969 <https://bugs.openjdk.java.net/browse/JDK-8147969>.
In jdk 9 this issue has been already addressed as part of the update
for JDK-8072452 <https://bugs.openjdk.java.net/browse/JDK-8072452>.
JBS:
8147969: Print size of DH keysize when errors are encountered
https://bugs.openjdk.java.net/browse/JDK-8147969
Webrev:
http://cr.openjdk.java.net/~snikandrova/8147969/webrev.00/
<http://cr.openjdk.java.net/%7Esnikandrova/8147969/webrev.00/>
Thank you,
Svetlana
