Changes look fine.
Thanks,
Valerie
On 8/10/2016 2:08 AM, Sibabrata Sahoo wrote:
Hi Valerie,
I have addressed the suggestion provided by Max to add "==" for the test policy files
because " lib/security/default.policy" file is included by default. I am waiting for your
suggestion to complete this review.
Here is the latest webrev: http://cr.openjdk.java.net/~ssahoo/8159964/webrev.02/
Thanks,
Siba
-----Original Message-----
From: Wang Weijun
Sent: Tuesday, August 09, 2016 1:21 PM
To: Sibabrata Sahoo
Cc: security-dev@openjdk.java.net; Valerie Peng
Subject: Re: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488
Deprivilege java.xml.crypto"
DeprivilegedModuleLoaderTest.java looks good to me.
I am not sure why you picked those 2 javax.xml.crypto tests. Have they have
covered the common functions? I'll let someone else to judge it.
BTW, I would prefer "java.security.policy==test.policy" (or just policy=test.policy) to
"java.security.policy=test.policy".
Thanks
Max
On 2016年8月9日, at 下午2:16, Sibabrata Sahoo <sibabrata.sa...@oracle.com> wrote:
Ping..
-----Original Message-----
From: Sibabrata Sahoo
Sent: Friday, August 05, 2016 7:28 PM
To: Weijun Wang; security-dev@openjdk.java.net; Valerie Peng
Subject: RE: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488
Deprivilege java.xml.crypto"
Hi Max,
Here is the updated webrev:
http://cr.openjdk.java.net/~ssahoo/8159964/webrev.01/
Thanks,
Siba
-----Original Message-----
From: Weijun Wang
Sent: Friday, August 05, 2016 4:19 PM
To: Sibabrata Sahoo; security-dev@openjdk.java.net; Valerie Peng
Subject: Re: [9] RFR: 8159964: Update Tests to verify JDK build for "JDK-8159488
Deprivilege java.xml.crypto"
I'm looking at DeprivilegedModuleLoaderTest.java.
Why not just call
classes.add(XMLSignatureFactory.class);
--Max
On 8/5/2016 18:00, Sibabrata Sahoo wrote:
Hi,
Please review the patch for "deprivilege java.xml.crypto,
java.security.jgss, jdk.security.jgss and jdk.security.auth" modules.
JBS: https://bugs.openjdk.java.net/browse/JDK-8159964
Webrev: http://cr.openjdk.java.net/~ssahoo/8159964/webrev.00/
Description:
This includes a new Test which verifies the classes from
"java.xml.crypto, java.security.jgss, jdk.security.jgss and
jdk.security.auth" modules get loaded through Platform Classloader.
It also includes modifying few existing test to run with Security
manager enabled.
Thanks,
Siba
