Thank you Vincent!
On 16.08.2016 16:27, Vincent Ryan wrote:
That fix looks fine. Is there any significant performance impact due to calling
CryptAcquireCertificatePrivateKey twice?
One of the intermittent attempts of implementing this enhancement was to
also get the handle to the private key (CryptGetUserKey), using the
silently acquired provider.
And only if *that* succeeded, we treated the probe successful and tried
to re-acquire the key normally.
However, that approach really introduced a significant slowdown
(approximately x2 times).
On the other hand, with the proposed variant, the slowdown isn't
noticeable by eye, but it surely will be worthwhile to do some benchmarking.
With kind regards,
Ivan
Thanks.
On 16 Aug 2016, at 13:56, Ivan Gerasimov <ivan.gerasi...@oracle.com> wrote:
A gentle reminder.
Would you please help review at your convenience.
With kind regards,
Ivan
On 09.08.2016 12:27, Ivan Gerasimov wrote:
Hello!
In order to reduce the number of popup dialog windows during accessing the smartcard, it
is proposed to first do a silent "probe" step.
Only if this probe succeeded, or if it failed due to that SILENT flag, we'll
try to re-acquire the key normally (i.e. not silently).
Would you please help review this proposal?
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8153438
WEBREV: http://cr.openjdk.java.net/~igerasim/8153438/00/webrev/
With kind regards,
Ivan
