Looks good. Thank you for the quick fix!

(I'm not an official reviewer.)

Thanks,
Amy

On 10/20/16 12:21 PM, Wang Weijun wrote:
Please review this test change:

diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java 
b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
--- a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
+++ b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
@@ -31,6 +31,7 @@
   * @library /lib/testlibrary warnings
   * @modules java.base/sun.security.pkcs
   *          java.base/sun.security.timestamp
+ *          java.base/sun.security.tools.keytool
   *          java.base/sun.security.util
   *          java.base/sun.security.x509
   *          java.management

TsacertOptionTest.java references another file TimestampCheck.java which uses a 
class in this private package, and compilation fails.

Unfortunately JPRT has not caught this because TimestampCheck.java was executed 
earlier (which itself is also a @test and includes the property @modules line).

Noreg-self.

Thanks
Max


Reply via email to