Looks fine. Small nit: new test has copyright 2003, 2016.
--Max > On Nov 16, 2016, at 11:45 AM, Jamil Nimeh <jamil.j.ni...@oracle.com> wrote: > > Good suggestions, thanks. > > Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8043252/webrev.02 > > --Jamil > > > On 11/15/2016 06:18 PM, Wang Weijun wrote: >> 41 System.setSecurityManager(new SecurityManager()); >> >> This is strange. I suppose you only want to trigger a permission check? >> >> If so, just change it to Policy.getPolicy(), and you can clean up the policy >> file a little. >> >> Thanks >> Max >> >>> On Nov 16, 2016, at 8:36 AM, Jamil Nimeh <jamil.j.ni...@oracle.com> wrote: >>> >>> Hello all, >>> >>> This fixes an issue in ProtectionDomain, where Permission classes that take >>> a loose interpretation of the getActions() method and return null cause an >>> NPE to be thrown when a ProtectionDomain's toString method is called >>> (during debugging for instance). >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8043252 >>> Webrev: http://cr.openjdk.java.net/~jnimeh/reviews/8043252/webrev.01/ >>> >>> Thanks, >>> --Jamil >
