I applied the patch to the jdk workspace and verified that all of the instances were updated to {@docRoot}/../specs/security/standard-names.html, and that no links remain to the old StandardNames.html.

Sean wrote:

> General: change the text of all of the links from "Java Cryptography
> Architecture Standard Algorithm Name Documentation" (the old name) to
> "Java Security Standard Algorithm Names Specification".

+1

Can you add similar wording to that effect in DrbgParameters.java?

jdk/src/java.base/share/classes/java/security/cert/CertPathValidator.java

155-156, 193-194:  extra spaces at beginning of line.

jdk/src/java.base/share/classes/javax/crypto/Cipher.java

153: Why did you choose to use "Cipher Algorithm Names" instead of Cipher Algorithms? None of the other sections use "Names".

Can you add a link in the JSSE KeyManagerFactory class description to the standard names sections for KeyManagerFactory's? Even though we don't require any currently, we should probably point to the names anyway.

Thanks,

Brad





On 5/5/2017 6:17 AM, Magnus Ihse Bursie wrote:
The Security Standard Names document will be moved to a new location, so
all links needs to be updated. Also, a minor fix to the build system was
needed.

Bug: https://bugs.openjdk.java.net/browse/JDK-8178278
WebRev:
http://cr.openjdk.java.net/~ihse/JDK-8178278-standard-names-spec-as-markdown/webrev.01

/Magnus

Reply via email to