> On May 5, 2017, at 3:52 PM, Jonathan Gibbons <jonathan.gibb...@oracle.com> > wrote: > > This is an updated review for the changes to improve tables in java.base. > : > Webrevs: > > langtools (the stylesheet): > http://cr.openjdk.java.net/~jjg/8179479-8179592/8179479/webrev.01/ > > jdk (changes to java.base): > http://cr.openjdk.java.net/~jjg/8179479-8179592/8179592/webrev.01/ > > API showing the combined effect of these cahnges: > http://cr.openjdk.java.net/~jjg/8179479-8179592/api.01/java.base-summary.html >
The new style class names are better. I reviewed the javadoc changes in java.base. Mostly looks good. A few table without an explicit class and FileSystemProvider should use striped class table. src/java.base/share/classes/java/nio/file/spi/FileSystemProvider.java - * <table border=1 cellpadding=5 summary=""> + * <table style="plain"> src/java.base/share/classes/java/nio/charset/Charset.java + * <blockquote><table style="width:80%”> src/java.base/share/classes/java/time/temporal/IsoFields.java - * <table cellpadding="0" cellspacing="3" border="0" style="text-align: left; width: 50%;"> + * <table style="text-align: left; width: 50%;”> src/java.base/share/classes/java/time/temporal/WeekFields.java - * <table cellpadding="0" cellspacing="3" border="0" style="text-align: left; width: 50%;"> + * <table style="text-align: left”> - * <table cellpadding="0" cellspacing="3" border="0" style="text-align: left; width: 50%;"> + * <table style="text-align: left;”> src/java.base/share/classes/java/util/ResourceBundle.java - * <table style="width: 50%; text-align: left; margin-left: 40px;" - * border="0" cellpadding="2" cellspacing="2" summary="locale-format combinations for newBundle"> + * <table style="width: 50%; text-align: left; margin-left: 40px;”> Mandy