Just a couple of comments:
- the same text is in KeyPairGeneratorSpi and
AlgorithmParameterGeneratorSpi so we should add the warning in those
classes too
- we should add the same warning to javax.crypto.KeyGenerator and
KeyGeneratorSpi
- Please change "Oracle Providers" to "JDK Providers", since all of
these providers are included in the JDK implementation, and we don't
want to include "Oracle" in the javadocs. (Plus the name of this guide
will be changed to "JDK Providers" at some point in the near future).
- Suggest changing the sentence "Even ..." to "Additionally, the default
value for a provider may change in a future version."
- s/Thus/Therefore/
--Sean
On 5/23/17 10:13 PM, Valerie Peng wrote:
Sean,
Can you please review this javadoc-only changes for JDK 9?
Bug: https://bugs.openjdk.java.net/browse/JDK-8180635
Webrev: http://cr.openjdk.java.net/~valeriep/8180635/webrev.00/
Thanks,
Valerie
