On 12/19/17 10:52 AM, Weijun Wang wrote:
* AesSha2DkCrypto.java

- why does stringToKey(char[] password, String salt, byte[] s2kparams) swallow 
exceptions but stringToKey(char[] secret, byte[] salt, byte[] params) does not?
I simply copy the behavior of the same methods for other etypes. Looks like the 
later is always private and called by the former. The former is called by 
EncryptionKey::acquireSecretKey and this method was designed to accept a null 
value instead of handle an exception.


Ok, I suggest logging the exception if debug is enabled.

--Sean

Reply via email to