I'll have a look Martin, but it'll be better if we can get an NSS or PKCS11 expert to take a look. Any takers ? Can you expand some bit on the exact reason for your 8195607 changes ? Pointers to NSS changes etc. ?

Regards,
Sean.

On 14/03/18 16:11, Martin Balao wrote:
Hi Sean,

Thanks!

Can you please review the fix [0] so we have it in? As far as I know, fix makes Oracle internal tests pass.

Kind regards,
Martin.-

--
[0] - http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html <http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html>

On Wed, Mar 14, 2018 at 12:05 PM, Seán Coffey <sean.cof...@oracle.com <mailto:sean.cof...@oracle.com>> wrote:

    Hi Martin,

    Thanks for the 8195607 pointer. I'll get this ported to jdk8u
    also. I didn't see that actual issue during testing but no harm to
    port it. Will submit a new webrev shortly.

    Regards,
    Sean.

    On 14/03/18 14:55, Martin Balao wrote:
    Hi Sean,

    Is this related to
    
http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html
    
<http://mail.openjdk.java.net/pipermail/security-dev/2018-February/016776.html> 
?

    Kind regards,
    Martin.-

    On Wed, Mar 14, 2018 at 11:48 AM, Seán Coffey
    <sean.cof...@oracle.com <mailto:sean.cof...@oracle.com>> wrote:

        Looking to backport this fix to jdk8u-dev.  Contributed to
        JDK Project by Martin Balao.

        https://bugs.openjdk.java.net/browse/JDK-8165996
        <https://bugs.openjdk.java.net/browse/JDK-8165996>
        webrev :
        http://cr.openjdk.java.net/~coffeys/webrev.8165996.8u/webrev/
        <http://cr.openjdk.java.net/%7Ecoffeys/webrev.8165996.8u/webrev/>

        The test/jdk/sun/security/pkcs11/PKCS11Test.java edits didn't
        seem applicable to jdk8u.

        Also, I edited
        sun/security/pkcs11/Secmod/TestNssDbSqlite.java to exclude
        test where NSS Provider
        didn't register. (line 66). In particular, I saw this while
        running 32bit JDK tests on 64 bit Linux.

-- Regards,
        Sean.





Reply via email to