Updated. I'm now using uri.substr(uri.indexOf("#") + 1).toUpperCase() as the
names.
Thanks
Max
> On May 24, 2018, at 4:47 AM, Sean Mullan <[email protected]> wrote:
>
> I don't think you should change the names of the algorithms to the JCE style
> (eg: SHA1withDSA). You should keep the names as defined by the W3C
> Recommendation and related RFCs. Even if the naming convention is different
> than JCE, these are the names that were chosen by the standards bodies and
> these are XML DSig specific algorithm names.
>
> Otherwise looks good.
>
> Thanks,
> Sean
>
> On 5/21/18 10:57 PM, Weijun Wang wrote:
>> Please take a review at
>> https://bugs.openjdk.java.net/browse/JDK-8203460
>> The current XMLDSig provider implementation is based on Apache Santuario
>> 1.5.4. We'll update it to be 2.1.1. New algorithms are added.
>> Thanks
>> Max
