There are a few typos in the CSR and an unfinished sentence in the Summary.

I think the Solution or Specification should say what standard APIs the underlying impl will be throwing an UnsupportedOperationException, i.e. SSLContextSpi.engineGetSocketFactory and engineGetServerSocketFactory. It's not apparent from the diffs unless you compare it against the full source code, so I think it would be helpful so you don't need to do that.

I also think the Interface Kind should be "Java API" since you are changing the JSSE DTLS implementation of a standard API.

Otherwise, looks ok.

--Sean

On 8/7/18 3:17 PM, Anthony Scarpino wrote:
I need a review of a CSR for SSLSocket should throw an exception when configuring DTLS.  We are targeting this for 12 right now.

https://bugs.openjdk.java.net/browse/JDK-8209031

thanks

Tony

Reply via email to